[webkit-reviews] review granted: [Bug 237278] Remove release assert when UI process is blocking IOSurface IOKit access : [Attachment 453405] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 28 14:33:10 PST 2022


Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 237278: Remove release assert when UI process is blocking IOSurface IOKit
access
https://bugs.webkit.org/show_bug.cgi?id=237278

Attachment 453405: Patch

https://bugs.webkit.org/attachment.cgi?id=453405&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 453405
  --> https://bugs.webkit.org/attachment.cgi?id=453405
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453405&action=review

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:299
> +	       // 64 bytes is currently the alignment on all platforms.
> +	       alignment = 64;

Why not just return a constant? We don’t need to call IOSurface just to feel
good.


More information about the webkit-reviews mailing list