[webkit-reviews] review granted: [Bug 237104] Fix for AXIsolatedTree::updateChildren in the case when is called for a non-existing isolated object. : [Attachment 453424] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 237104: Fix for AXIsolatedTree::updateChildren in the case when is called
for a non-existing isolated object.
https://bugs.webkit.org/show_bug.cgi?id=237104

Attachment 453424: Patch

https://bugs.webkit.org/attachment.cgi?id=453424&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 453424
  --> https://bugs.webkit.org/attachment.cgi?id=453424
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453424&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:437
> +    auto isAncestor = Function<FilterResponse(const
AXCoreObject&)>([&axDescendant] (const AXCoreObject& axAncestor) {

I’d think we’d want this local to just be the lambda and construct the function
as a side effect of passing it to collectNodeChangesForSubtree. Did you try
that?

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:398
> +    enum class FilterResponse : uint8_t {
> +	   Include,
> +	   Skip,
> +	   Stop,
> +    };

I think these read better as one-liners.