[webkit-reviews] review granted: [Bug 237183] [Cocoa] Allow logging to be configured by NSDefaults (without regressing launch time) : [Attachment 453417] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 28 13:58:55 PST 2022


Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 237183: [Cocoa] Allow logging to be configured by NSDefaults (without
regressing launch time)
https://bugs.webkit.org/show_bug.cgi?id=237183

Attachment 453417: Patch

https://bugs.webkit.org/attachment.cgi?id=453417&action=review




--- Comment #16 from Darin Adler <darin at apple.com> ---
Comment on attachment 453417
  --> https://bugs.webkit.org/attachment.cgi?id=453417
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453417&action=review

> Source/WebKit/UIProcess/Cocoa/UIProcessLogInitializationCocoa.mm:42
> +	   logString.get() = [[NSUserDefaults standardUserDefaults]
stringForKey:@"WTFLogging"];

Do we need the ".get()" on these lines?


More information about the webkit-reviews mailing list