[webkit-reviews] review granted: [Bug 236505] WebGL GPUP OpenGL context is not used even if WebGL via Metal is deselected : [Attachment 453408] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 236505: WebGL GPUP OpenGL context is not used even if WebGL via Metal is
deselected
https://bugs.webkit.org/show_bug.cgi?id=236505

Attachment 453408: Patch

https://bugs.webkit.org/attachment.cgi?id=453408&action=review




--- Comment #7 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 453408
  --> https://bugs.webkit.org/attachment.cgi?id=453408
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453408&action=review

> Source/WebCore/platform/graphics/GraphicsContextGLAttributes.h:80
> +#if ENABLE(GPU_PROCESS)

Is there harm in leaving these functions in, even if !ENABLE(GPU_PROCESS)? I
generally view #ifs as worse than leaving in unused functions.