[webkit-reviews] review granted: [Bug 220925] [webkit-patch] Allow user to opt out of browser for viewing the diff : [Attachment 418397] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Angelos Oikonomopoulos
<angelos at igalia.com>'s request for review:
Bug 220925: [webkit-patch] Allow user to opt out of browser for viewing the
diff
https://bugs.webkit.org/show_bug.cgi?id=220925

Attachment 418397: Patch

https://bugs.webkit.org/attachment.cgi?id=418397&action=review




--- Comment #16 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 418397
  --> https://bugs.webkit.org/attachment.cgi?id=418397
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418397&action=review

> Tools/Scripts/webkitpy/tool/steps/confirmdiff.py:54
> +	   if os.environ.get('WEBKIT_PATCH_PREFER_PAGER') or not
self._tool.user.can_open_url():

r+ing this for now, but this will be more relevant in git-webkit, where we'll
probably do this with a git config option.