[webkit-reviews] review granted: [Bug 236109] [Cocoa] Adopt -streamDataParser:didProvideContentKeySpecifier:forTrackID: delegate callback : [Attachment 453313] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 236109: [Cocoa] Adopt
-streamDataParser:didProvideContentKeySpecifier:forTrackID: delegate callback
https://bugs.webkit.org/show_bug.cgi?id=236109

Attachment 453313: Patch

https://bugs.webkit.org/attachment.cgi?id=453313&action=review




--- Comment #24 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 453313
  --> https://bugs.webkit.org/attachment.cgi?id=453313
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453313&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm
:229
> +#if HAVE(AVCONTENTKEYSPECIFIER)
> +    if
(MediaSessionManagerCocoa::sampleBufferContentKeySessionSupportEnabled())
> +	   m_delegate = adoptNS([[WebAVStreamDataParserWithKeySpecifierListener
alloc] initWithParser:m_parser.get() parent:this]);
> +    else
> +#endif

You already do runtime checks to make sure AVSampleBufferAudioRenderer and
AVSampleBufferDisplayLayer conform to the new protocols, so can you get rid of
the HAVE(AVCONTENTKEYSPECIFIER) here and above so you can always create a
WebAVStreamDataParserWithKeySpecifierListener to make this easier to read and
follow?