[webkit-reviews] review granted: [Bug 237244] Force -webkit-user-modify effective style to readonly for inert nodes : [Attachment 453331] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tim Nguyen (:ntim) <ntim at apple.com>'s
request for review:
Bug 237244: Force -webkit-user-modify effective style to readonly for inert
nodes
https://bugs.webkit.org/show_bug.cgi?id=237244

Attachment 453331: Patch

https://bugs.webkit.org/attachment.cgi?id=453331&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 453331
  --> https://bugs.webkit.org/attachment.cgi?id=453331
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453331&action=review

> Source/WebCore/rendering/style/RenderStyle.h:617
> +    UserModify effectiveUserModify() const { return effectiveInert() ?
UserModify::ReadOnly : userModify(); }

Maybe these "effective" functions should be in a separate paragraph, rather
than being interspersed with the getters for the actual stored values?

Some day we might even automatically generate or do something else like that
for the stored values, and the effective family of functions seems like a
different thing.