[webkit-reviews] review granted: [Bug 45113] FTP EPLF does not handle directory : [Attachment 453305] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Pascal Abresch
<nep-webkit at packageloss.eu>'s request for review:
Bug 45113: FTP EPLF does not handle directory
https://bugs.webkit.org/show_bug.cgi?id=45113

Attachment 453305: Patch

https://bugs.webkit.org/attachment.cgi?id=453305&action=review




--- Comment #28 from Darin Adler <darin at apple.com> ---
Comment on attachment 453305
  --> https://bugs.webkit.org/attachment.cgi?id=453305
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453305&action=review

Thanks so much for this contribution. Looks good.

> Source/WebCore/ChangeLog:17
> +	   Test: http/tests/misc/ftp-eplf-directory-expected.txt

Ideally this should list the test, ftp-eplf-directory.py, not the expected
result file.

Really unfortunate there is no way to make an FTP test use text-style results
instead of render tree dumps. We’ll have to rebase these expected results any
time there are rendering changes (unrelated to FTP).