[webkit-reviews] review granted: [Bug 237065] [macOS] TestWebKitAPI.WebKit.MigrateLocalStorageDataToGeneralStorageDirectory is a flaky failure : [Attachment 453229] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Sihui Liu
<sihui_liu at apple.com>'s request for review:
Bug 237065: [macOS]
TestWebKitAPI.WebKit.MigrateLocalStorageDataToGeneralStorageDirectory is a
flaky failure
https://bugs.webkit.org/show_bug.cgi?id=237065

Attachment 453229: Patch

https://bugs.webkit.org/attachment.cgi?id=453229&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 453229
  --> https://bugs.webkit.org/attachment.cgi?id=453229
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453229&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:264
>      // Make sure we flush all cookies to disk before exiting.

This comment should probably be omitted. Typically, we want comments to explain
"why", not "what". This comment just explains what, and it's not even entirely
accurate any more after this addition.

> Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp:89
> +	   std::atexit(commitTransactionsAtExit);

Do we still have a boost to prevent suspension at this point?