[webkit-reviews] review granted: [Bug 237176] [JSC] Use DeferTerminationForAWhile in Interpreter::unwind : [Attachment 453255] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 237176: [JSC] Use DeferTerminationForAWhile in Interpreter::unwind
https://bugs.webkit.org/show_bug.cgi?id=237176

Attachment 453255: Patch

https://bugs.webkit.org/attachment.cgi?id=453255&action=review




--- Comment #8 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 453255
  --> https://bugs.webkit.org/attachment.cgi?id=453255
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453255&action=review

r=me

> Source/JavaScriptCore/interpreter/Interpreter.cpp:712
> +    // On the other hand, we do not clear already a raised termination
exception because it is possible

/already a raised/an already raised/

> Source/JavaScriptCore/interpreter/Interpreter.cpp:715
> +    // What we would like to achieve here is do not raise a new termination
exception while running

/is do not/is to not/