[webkit-reviews] review granted: [Bug 236769] [GTK][WPE][WC] Move ANGLE context initialisation to GraphicsContextGLTextureMapper::initialize : [Attachment 453156] Fix WinCairo

[bugzilla-daemon at webkit.org]

Chris Lord <clord at igalia.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 236769: [GTK][WPE][WC] Move ANGLE context initialisation to
GraphicsContextGLTextureMapper::initialize
https://bugs.webkit.org/show_bug.cgi?id=236769

Attachment 453156: Fix WinCairo

https://bugs.webkit.org/attachment.cgi?id=453156&action=review




--- Comment #13 from Chris Lord <clord at igalia.com> ---
Comment on attachment 453156
  --> https://bugs.webkit.org/attachment.cgi?id=453156
Fix WinCairo

View in context: https://bugs.webkit.org/attachment.cgi?id=453156&action=review

I take it back, I can reproduce the crash pre-patch so it would appear
unrelated. I also tested this on WPE, compiling both with and without ANGLE
enabled and it built and functioned correctly. LGTM!

> Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapper.h:67
> +    bool platformInitializeContext() final;
> +#endif
> +    bool platformInitialize() final;

It feels weird to me that these are two separate functions, but that's
pre-existing so I assume there's a reason. I think at some point it would be
good to consolidate here, we have initialize, platformInitialize and
platformInitializeContext - this feels like at least one too many functions and
certainly doesn't make for easy reading.