[webkit-reviews] review granted: [Bug 237156] Take down shared worker context connection less aggressively when it becomes idle : [Attachment 453135] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 237156: Take down shared worker context connection less aggressively when
it becomes idle
https://bugs.webkit.org/show_bug.cgi?id=237156

Attachment 453135: Patch

https://bugs.webkit.org/attachment.cgi?id=453135&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 453135
  --> https://bugs.webkit.org/attachment.cgi?id=453135
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453135&action=review

>
Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnect
ion.cpp:146
> +    // Terminate context connection after a little while if it is no longer
used by any SharedWorker objects.

If I was doing this change, I’d put this comment on the constant rather than
the code that uses it. Not sure that’s better, though.