[webkit-reviews] review requested: [Bug 237129] [XCBuild] WTF's SPI dependencies are copied via a folder reference and do not emit task outputs : [Attachment 453147] Patch for relanding

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 24 16:05:22 PST 2022


Elliott Williams <emw at apple.com> has asked  for review:
Bug 237129: [XCBuild] WTF's SPI dependencies are copied via a folder reference
and do not emit task outputs
https://bugs.webkit.org/show_bug.cgi?id=237129

Attachment 453147: Patch for relanding

https://bugs.webkit.org/attachment.cgi?id=453147&action=review




--- Comment #9 from Elliott Williams <emw at apple.com> ---
Created attachment 453147

  --> https://bugs.webkit.org/attachment.cgi?id=453147&action=review

Patch for relanding

The original patch was missing a build rule for subdirectories of Scripts/, so
Scripts/Preferences/* was being copied to /usr/local/include/Scripts.

Tested with a clean build locally.


More information about the webkit-reviews mailing list