[webkit-reviews] review granted: [Bug 237151] [iOS] Add support for replacing WKFoundTextRanges : [Attachment 453124] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 24 13:01:53 PST 2022


Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 237151: [iOS] Add support for replacing WKFoundTextRanges
https://bugs.webkit.org/show_bug.cgi?id=237151

Attachment 453124: Patch

https://bugs.webkit.org/attachment.cgi?id=453124&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 453124
  --> https://bugs.webkit.org/attachment.cgi?id=453124
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453124&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10432
> +    return self.webView._editable;

It's a tiny bit surprising that this is only for Mail compose. I suppose that's
because there's no per-text-range notion of editability baked into the API yet?


More information about the webkit-reviews mailing list