[webkit-reviews] review granted: [Bug 237129] [XCBuild] WTF's SPI dependencies are copied via a folder reference and do not emit task outputs : [Attachment 453075] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Elliott Williams
<emw at apple.com>'s request for review:
Bug 237129: [XCBuild] WTF's SPI dependencies are copied via a folder reference
and do not emit task outputs
https://bugs.webkit.org/show_bug.cgi?id=237129

Attachment 453075: Patch

https://bugs.webkit.org/attachment.cgi?id=453075&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 453075
  --> https://bugs.webkit.org/attachment.cgi?id=453075
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453075&action=review

> Source/WTF/WTF.xcodeproj/project.pbxproj:822
> +			       
"$(HEADER_OUTPUT_DIR)/$(INPUT_FILE_DIR:dir:standardizepath:base)/$(INPUT_FILE_D
IR:base)/$(INPUT_FILE_NAME)",

Nice.

> Source/WTF/WTF.xcodeproj/project.pbxproj:825
> +			script = "cp -f \"${INPUT_FILE_PATH}\"
\"${SCRIPT_OUTPUT_FILE_0}\"\n";

Not sure if this matters at all, but do we want to preserve timestamps?

> Source/WTF/WTF.xcodeproj/project.pbxproj:872
> -			dstSubFolderSpec = 0;
> +			dstSubfolderSpec = 0;

:-O