[webkit-reviews] review granted: [Bug 237098] Port CaptivePortalMode preferences to AnyHost in order to support CFPrefs Direct Mode propagation : [Attachment 453105] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Gavin <gavin.p at apple.com>'s
request for review:
Bug 237098: Port CaptivePortalMode preferences to AnyHost in order to support
CFPrefs Direct Mode propagation
https://bugs.webkit.org/show_bug.cgi?id=237098

Attachment 453105: Patch

https://bugs.webkit.org/attachment.cgi?id=453105&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 453105
  --> https://bugs.webkit.org/attachment.cgi?id=453105
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453105&action=review

r=me

> Source/WebKit/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=237098

<rdar://problem/89373662>

Please always include the Radar in Changelogs, as it makes it easier to find
things using the Xcode change viewer.

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:748
> +#if PLATFORM(COCOA)

Oops -- yes, this would never have worked properly for macOS!