[webkit-reviews] review granted: [Bug 237142] Regression(r273929) FrameState no longer gets a move constructor : [Attachment 453106] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 237142: Regression(r273929) FrameState no longer gets a move constructor
https://bugs.webkit.org/show_bug.cgi?id=237142

Attachment 453106: Patch

https://bugs.webkit.org/attachment.cgi?id=453106&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 453106
  --> https://bugs.webkit.org/attachment.cgi?id=453106
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453106&action=review

> Source/WebKit/Shared/SessionState.h:93
> +    FrameState(const FrameState&) = default;
> +    FrameState(FrameState&&) = default;
> +    FrameState& operator=(const FrameState&) = default;
> +    FrameState& operator=(FrameState&&) = default;

I’d think we’d want the "main run loop" assertion on these other constructors
too, maybe even the assignment operators, but sadly could not take advantage of
the defaults then. Valuable to group these with the constructor/destructor
pair, since we should delete them all at the same time.