[webkit-reviews] review granted: [Bug 237127] Refactor logic for showing "Markup Image" and Quick Note items in the callout bar : [Attachment 453068] For EWS

[bugzilla-daemon at webkit.org]

Megan Gardner <megan_gardner at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 237127: Refactor logic for showing "Markup Image" and Quick Note items in
the callout bar
https://bugs.webkit.org/show_bug.cgi?id=237127

Attachment 453068: For EWS

https://bugs.webkit.org/attachment.cgi?id=453068&action=review




--- Comment #3 from Megan Gardner <megan_gardner at apple.com> ---
Comment on attachment 453068
  --> https://bugs.webkit.org/attachment.cgi?id=453068
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=453068&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:96
> +    EXPECT_FALSE([menuBuilder
containsActionWithTitle:WebCore::contextMenuItemTagAddHighlightToNewQuickNote()
]);

You should still test for both App Highlight menu items. If things change
around the logic for which item to show when, it's unlikely that this test
would be updated as a part of that. So, best to just do it now.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:104
> +    EXPECT_TRUE([menuBuilder
containsActionWithTitle:WebCore::contextMenuItemTagAddHighlightToNewQuickNote()
]);

ditto.