[webkit-reviews] review granted: [Bug 237134] RemoteCaptureSampleManager, UserMediaSampleCaptureManagerProxy create the RemoteVideoFrame incorrectly : [Attachment 453088] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 24 05:36:37 PST 2022
youenn fablet <youennf at gmail.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 237134: RemoteCaptureSampleManager, UserMediaSampleCaptureManagerProxy
create the RemoteVideoFrame incorrectly
https://bugs.webkit.org/show_bug.cgi?id=237134
Attachment 453088: Patch
https://bugs.webkit.org/attachment.cgi?id=453088&action=review
--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 453088
--> https://bugs.webkit.org/attachment.cgi?id=453088
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=453088&action=review
> Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:207
> +
m_connection->send(Messages::RemoteCaptureSampleManager::VideoSampleAvailable(m
_id, WTFMove(properties), metadata), 0);
No need for WTFMove.
> Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:213
> +
m_connection->send(Messages::RemoteCaptureSampleManager::VideoSampleAvailableCV
(m_id, WTFMove(*remoteSample), metadata), 0);
No need for WTFMove.
More information about the webkit-reviews
mailing list