[webkit-reviews] review granted: [Bug 236832] Thread safety analysis to assert "code is run sequentially" is not useful when code is mainly run with WorkQueues : [Attachment 452973] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 24 00:05:58 PST 2022


Antti Koivisto <koivisto at iki.fi> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 236832: Thread safety analysis to assert "code is run sequentially" is not
useful when code is mainly run with WorkQueues
https://bugs.webkit.org/show_bug.cgi?id=236832

Attachment 452973: Patch

https://bugs.webkit.org/attachment.cgi?id=452973&action=review




--- Comment #26 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 452973
  --> https://bugs.webkit.org/attachment.cgi?id=452973
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452973&action=review

r=me, cool patch

> Source/WTF/wtf/Threading.h:106
> +class WTF_CAPABILITY("is current") Thread : public
ThreadSafeRefCounted<Thread> {

Space here looks od but I suppose it is ok.


More information about the webkit-reviews mailing list