[webkit-reviews] review granted: [Bug 237126] [MacCatalyst] REGRESSION(r290091): sometimes can crash if `WKWebView` is deallocated before the next visible content rect update : [Attachment 453065] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 237126: [MacCatalyst] REGRESSION(r290091): sometimes can crash if
`WKWebView` is deallocated before the next visible content rect update
https://bugs.webkit.org/show_bug.cgi?id=237126

Attachment 453065: Patch

https://bugs.webkit.org/attachment.cgi?id=453065&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 453065
  --> https://bugs.webkit.org/attachment.cgi?id=453065
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453065&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewResize.mm:44
> +	   if ([exception.name hasPrefix:@"Assertion deallocated before it was
invalidated."])

Any exception during dealloc would be bad, not sure why you’re being so
specific (and making the test extremely susceptible to false positives if the
string changes)