[webkit-reviews] review granted: [Bug 200195] [JSC] WeakMapImpl do not need to take cellLock in visitOutputConstraints and main thread : [Attachment 453060] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 200195: [JSC] WeakMapImpl do not need to take cellLock in
visitOutputConstraints and main thread
https://bugs.webkit.org/show_bug.cgi?id=200195

Attachment 453060: Patch

https://bugs.webkit.org/attachment.cgi?id=453060&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 453060
  --> https://bugs.webkit.org/attachment.cgi?id=453060
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453060&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +	   WeakMapImpl::visitOutputConstraints is called in the constraint
solver, and it does not modify the buffer of WeakMapImpl.

Can you remove this part: "and it does not modify the buffer of WeakMapImpl"? 
It is not relevant, correct?  The only relevant detail is what you stated below
i.e. the constraint solver runs and rehash can never be run concurrently.

Also, if concurrency were an issue, m_buffer isn't the only thing that needs to
be protected: m_capacity does too.  So, it seems strange to draw attention to
the buffer here.