[webkit-reviews] review granted: [Bug 236533] Web Inspector: merge WI.OverlayManager into WI.DOMNode : [Attachment 452787] [fast-cq] Patch

[bugzilla-daemon at webkit.org]

Patrick Angle <pangle at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 236533: Web Inspector: merge WI.OverlayManager into WI.DOMNode
https://bugs.webkit.org/show_bug.cgi?id=236533

Attachment 452787: [fast-cq] Patch

https://bugs.webkit.org/attachment.cgi?id=452787&action=review




--- Comment #5 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 452787
  --> https://bugs.webkit.org/attachment.cgi?id=452787
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452787&action=review

r=me

>
Source/WebInspectorUI/UserInterface/Controllers/GridOverlayConfigurationDiagnos
ticEventRecorder.js:35
> +	   this._nodesShowingGridLayoutOverlay = new Set;

Is there a way we can do this by just keeping a balanced count instead of
keeping the nodes around, or do the events that are fired not guarantee any
sort of balanced calls? If not, can we add a listener for node removal (or
maybe just a new event called from WI.DOMManager.prototype.willDestroyDOMNode)
to also remove it from this set?