[webkit-reviews] review granted: [Bug 237109] [WebAuthn] Use default pubKeyCredParams if empty in makeCredential : [Attachment 453044] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 237109: [WebAuthn] Use default pubKeyCredParams if empty in makeCredential
https://bugs.webkit.org/show_bug.cgi?id=237109

Attachment 453044: Patch

https://bugs.webkit.org/attachment.cgi?id=453044&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 453044
  --> https://bugs.webkit.org/attachment.cgi?id=453044
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453044&action=review

Nice! r=me

> Source/WebCore/ChangeLog:8
> +	   The Web Authentication level 2 spec added that a set of default
pubKeyCredParams

"level 2 spec was updated to clarify that a set of default pubKeyCredParams
should be used if the list supplied by the RP is empty."