[webkit-reviews] review granted: [Bug 237115] [XCBuild] Don't automatically use the ../Internal/WebKit workspace : [Attachment 453034] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Elliott Williams
<emw at apple.com>'s request for review:
Bug 237115: [XCBuild] Don't automatically use the ../Internal/WebKit workspace
https://bugs.webkit.org/show_bug.cgi?id=237115

Attachment 453034: Patch

https://bugs.webkit.org/attachment.cgi?id=453034&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 453034
  --> https://bugs.webkit.org/attachment.cgi?id=453034
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453034&action=review

High level question tangentially related to this patch: will workspace builds
allow for changing a file in WebCore, and rebuilding just WebCore `make -C
Source/WebCore` without linking all dependent projects? Often, engineers know
that there is no API change, and relinking everything would waste time.

> Makefile.shared:-9
> -	$(dir $(lastword
$(MAKEFILE_LIST)))../Internal/WebKit/WebKit.xcworkspace \

I'm curious why this patch touches so many files, as opposed to just removing
this line.