[webkit-reviews] review granted: [Bug 237089] BubbleWrap launcher doesn't bind font locations from XDG_DATA_DIRS : [Attachment 453016] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted apteryx
<maxim.cournoyer at gmail.com>'s request for review:
Bug 237089: BubbleWrap launcher doesn't bind font locations from XDG_DATA_DIRS
https://bugs.webkit.org/show_bug.cgi?id=237089

Attachment 453016: Patch

https://bugs.webkit.org/attachment.cgi?id=453016&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 453016
  --> https://bugs.webkit.org/attachment.cgi?id=453016
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453016&action=review

I agree, except for code style nits:

> Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:308
> +    for (auto dataDir = dataDirs; dataDir != nullptr && *dataDir != nullptr;
dataDir++) {

I'm surprised the style bot didn't complain about this. Always write out the *
on auto* to make it more clear that it's a pointer, and never explicitly
compare against nullptr:

for (auto* dataDir = dataDirs; dataDir && *dataDir; dataDir++) {