[webkit-reviews] review granted: [Bug 237099] Adopt more widely the new URL constructor that takes in a String : [Attachment 453008] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 23 13:56:25 PST 2022


Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 237099: Adopt more widely the new URL constructor that takes in a String
https://bugs.webkit.org/show_bug.cgi?id=237099

Attachment 453008: Patch

https://bugs.webkit.org/attachment.cgi?id=453008&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 453008
  --> https://bugs.webkit.org/attachment.cgi?id=453008
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453008&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:881
> -    URL url(URL(), uriString);
> +    URL url { uriString };
>      return url;

I would have merged these into one line.

> Source/WebCore/platform/win/PasteboardWin.cpp:614
> +	   URL kurl { url };

"kurl", ha ha ha


More information about the webkit-reviews mailing list