[webkit-reviews] review granted: [Bug 237098] Observe preference changes from the currentHost : [Attachment 453007] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Gavin <gavin.p at apple.com>'s
request for review:
Bug 237098: Observe preference changes from the currentHost
https://bugs.webkit.org/show_bug.cgi?id=237098

Attachment 453007: Patch

https://bugs.webkit.org/attachment.cgi?id=453007&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 453007
  --> https://bugs.webkit.org/attachment.cgi?id=453007
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453007&action=review

r=me

>> Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm:76
>> +	    auto hostValue = adoptCF(CFPreferencesCopyValue((__bridge
CFStringRef)key, kCFPreferencesAnyApplication, kCFPreferencesCurrentUser,
kCFPreferencesCurrentHost));
> 
> If CurrentHost and AnyHost are treated the same on iOS, should we
conditionalize this on PLATFORM(MAC), or maybe !PLATFORM(IOS)?

I talked with Gavin offline, and we actually do want it to work this way on all
platforms.