[webkit-reviews] review granted: [Bug 237090] [IFC][Integration] LineLayout::firstLinePhysicalBaseline/lastLineLogicalBaseline should flip box baseline value for vertical-lr : [Attachment 452992] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 237090: [IFC][Integration]
LineLayout::firstLinePhysicalBaseline/lastLineLogicalBaseline should flip box
baseline value for vertical-lr
https://bugs.webkit.org/show_bug.cgi?id=237090

Attachment 452992: Patch

https://bugs.webkit.org/attachment.cgi?id=452992&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 452992
  --> https://bugs.webkit.org/attachment.cgi?id=452992
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452992&action=review

> Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:466
> +    switch (rootLayoutBox().style().writingMode()) {
> +    case WritingMode::TopToBottom:

wonder if the switch could be usefully shared between first/last cases?