[webkit-reviews] review granted: [Bug 237085] Share more code between service and shared workers for context connection establishment : [Attachment 452981] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 237085: Share more code between service and shared workers for context
connection establishment
https://bugs.webkit.org/show_bug.cgi?id=237085

Attachment 452981: Patch

https://bugs.webkit.org/attachment.cgi?id=452981&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 452981
  --> https://bugs.webkit.org/attachment.cgi?id=452981
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452981&action=review

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in:59
> +    EstablishRemoteWorkerContextConnectionToNetworkProcess(enum:uint32_t
WebKit::RemoteWorkerType workerType, WebCore::RegistrableDomain
registrableDomain, std::optional<WebCore::ProcessIdentifier>
requestingProcessIdentifier,
std::optional<WebCore::ScriptExecutionContextIdentifier>
serviceWorkerPageIdentifier, PAL::SessionID sessionID) -> () Async

Why is it a uint32_t, should it not be either a bool or maybe a uint8_t?

> Source/WebKit/UIProcess/WebProcessPool.cpp:558
> +    bool shouldUseSeparateRemoteWorkerProcess = workerType ==
RemoteWorkerType::ServiceWorker && s_useSeparateServiceWorkerProcess;

We might want to use s_useSeparateServiceWorkerProcess for shared workers as
well for testing things like crash of shared worker process.