[webkit-reviews] review granted: [Bug 237084] [GStreamer] De-initialize GStreamer before terminating WebProcess : [Attachment 452977] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 237084: [GStreamer] De-initialize GStreamer before terminating WebProcess
https://bugs.webkit.org/show_bug.cgi?id=237084

Attachment 452977: Patch

https://bugs.webkit.org/attachment.cgi?id=452977&action=review




--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 452977
  --> https://bugs.webkit.org/attachment.cgi?id=452977
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452977&action=review

> Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp:75
> +#if USE(GSTREAMER)
> +	   gst_deinit();
> +#endif

Don't we need to include a gst header for this?

> Source/WebKit/WebProcess/wpe/WebProcessMainWPE.cpp:107
> +#if USE(GSTREAMER)
> +	   gst_deinit();
> +#endif

Ditto.