[webkit-reviews] review granted: [Bug 237052] Prevent use of PDFKit when using PDF.js : [Attachment 452906] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 237052: Prevent use of PDFKit when using PDF.js
https://bugs.webkit.org/show_bug.cgi?id=237052

Attachment 452906: Patch

https://bugs.webkit.org/attachment.cgi?id=452906&action=review




--- Comment #10 from Tim Horton <thorton at apple.com> ---
Comment on attachment 452906
  --> https://bugs.webkit.org/attachment.cgi?id=452906
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452906&action=review

> Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:209
>      return pdfPluginEnabled()
> +	   && !corePage()->settings().pdfJSViewerEnabled()

Does anyone call pdfPluginEnabled() (as opposed to shouldUsePDFPlugin) that
might motivate you to move this check down a level?