[webkit-reviews] review granted: [Bug 237047] Refactor DOMWindow calls generating console warnings into a single DOMWindow::printWarningMessage method : [Attachment 452896] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tim Nguyen (:ntim) <ntim at apple.com>'s
request for review:
Bug 237047: Refactor DOMWindow calls generating console warnings into a single
DOMWindow::printWarningMessage method
https://bugs.webkit.org/show_bug.cgi?id=237047

Attachment 452896: Patch

https://bugs.webkit.org/attachment.cgi?id=452896&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 452896
  --> https://bugs.webkit.org/attachment.cgi?id=452896
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452896&action=review

> Source/WebCore/page/DOMWindow.h:273
> +    void printConsoleMessage(const String&, MessageLevel) const;
>      void printErrorMessage(const String&) const;
> +    void printWarningMessage(const String&) const;

Can these all be private? Is there any caller using them outside the class?