[webkit-reviews] review granted: [Bug 237062] PingLoader is failing to call completion handler in error case : [Attachment 452907] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 237062: PingLoader is failing to call completion handler in error case
https://bugs.webkit.org/show_bug.cgi?id=237062

Attachment 452907: Patch

https://bugs.webkit.org/attachment.cgi?id=452907&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 452907
  --> https://bugs.webkit.org/attachment.cgi?id=452907
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452907&action=review

> Source/WebKit/NetworkProcess/PingLoad.cpp:143
> +	       completionHandler({ });

Is there a reason we need to call this before the didFinish() call?
Would seem more logical the other way around for me.