[webkit-reviews] review granted: [Bug 237002] CachedResourceLoader::allCachedSVGImages() reparses resource URLs unnecessarily : [Attachment 452790] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 237002: CachedResourceLoader::allCachedSVGImages() reparses resource URLs
unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=237002

Attachment 452790: Patch

https://bugs.webkit.org/attachment.cgi?id=452790&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 452790
  --> https://bugs.webkit.org/attachment.cgi?id=452790
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452790&action=review

> Source/WebCore/ChangeLog:10
> +	   Store URLs in the HashMaps instead of Strings since we have URLs
initially and we
> +	   need URLs eventually. This avoids having to re-parse the URL
unnecessarily, which
> +	   is fairly expensive.

It also makes the maps bigger; URLs share the strings, but the parsed offsets
are separate in each URL. Hope that extra memory use is OK.