[webkit-reviews] review granted: [Bug 235836] Inert subtrees fail to block activation from contained svg elements : [Attachment 452854] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 235836: Inert subtrees fail to block activation from contained svg elements
https://bugs.webkit.org/show_bug.cgi?id=235836

Attachment 452854: Patch

https://bugs.webkit.org/attachment.cgi?id=452854&action=review




--- Comment #9 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 452854
  --> https://bugs.webkit.org/attachment.cgi?id=452854
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452854&action=review

> Source/WebCore/ChangeLog:9
> +	   Re-using visibleToHitTesting in SVG code isn't possible, because
visibleToHitTesting removes visibility: hidden;
> +	   content from hit-testing, which we do not want to here, since
pointer-events has values for SVG which still

That's pretty silly. SVG spec really makes invisible things hittable?

> Source/WebCore/rendering/style/RenderStyle.h:716
> +    PointerEvents pointerEventsIncludingInert() const { return
effectiveInert() ? PointerEvents::None : pointerEvents(); }

I think you proposed effectiveUserSelect() earlier but we then went with
*IncludingInert instead. I think you were right and we should just go with
effective* with all these (it reads better and is more expandable), wether
backed by a fake property or not.