[webkit-reviews] review granted: [Bug 236643] [JSC] Guard against dead remotes in numberOfProcessors : [Attachment 452720] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Angelos Oikonomopoulos
<angelos at igalia.com>'s request for review:
Bug 236643: [JSC] Guard against dead remotes in numberOfProcessors
https://bugs.webkit.org/show_bug.cgi?id=236643

Attachment 452720: Patch

https://bugs.webkit.org/attachment.cgi?id=452720&action=review




--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 452720
  --> https://bugs.webkit.org/attachment.cgi?id=452720
Patch

r=me

View in context: https://bugs.webkit.org/attachment.cgi?id=452720&action=review

> Tools/Scripts/run-jsc-stress-tests:2585
> +	       numProcessors = runCommandOnTester("sysctl -n hw.activecpu
2>/dev/null || nproc --all 2>/dev/null").to_i

I wonder if it would be better/good to use “getconf _NPROCESSORS_ONLN“ or have
it as yet another fallback ��️

Anyway, just a thought, no need to update the patch for it.