[webkit-reviews] review granted: [Bug 237021] http/wpt/mediarecorder/mute-tracks.html fails with WebRTCRemoteVideoFrameEnabled=true : [Attachment 452833] Patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 237021: http/wpt/mediarecorder/mute-tracks.html fails with
WebRTCRemoteVideoFrameEnabled=true
https://bugs.webkit.org/show_bug.cgi?id=237021

Attachment 452833: Patch

https://bugs.webkit.org/attachment.cgi?id=452833&action=review




--- Comment #2 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 452833
  --> https://bugs.webkit.org/attachment.cgi?id=452833
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452833&action=review

> Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:99
>	   // FIXME: We could optimize sending black frames by only sending
width/height.

I think it'd be the time to address the fixme. Sending dummy pixels of possibly
invalid size..