[webkit-reviews] review granted: [Bug 236952] Permission API: handle non-fully active documents : [Attachment 452832] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Marcos Caceres
<marcos at marcosc.com>'s request for review:
Bug 236952: Permission API: handle non-fully active documents
https://bugs.webkit.org/show_bug.cgi?id=236952

Attachment 452832: Patch

https://bugs.webkit.org/attachment.cgi?id=452832&action=review




--- Comment #10 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 452832
  --> https://bugs.webkit.org/attachment.cgi?id=452832
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452832&action=review

> Source/WebCore/Modules/permissions/PermissionStatus.cpp:72
> +    auto* context = scriptExecutionContext();

Not really needed

> Source/WebCore/Modules/permissions/PermissionStatus.cpp:73
> +    if (auto document = dynamicDowncast<Document>(context);
!document->isFullyActive())

I would use auto* to match Permissions::query.