[webkit-reviews] review granted: [Bug 236936] [JSC] Temporal.PlainDate should validate input range : [Attachment 452781] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 236936: [JSC] Temporal.PlainDate should validate input range
https://bugs.webkit.org/show_bug.cgi?id=236936

Attachment 452781: Patch

https://bugs.webkit.org/attachment.cgi?id=452781&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 452781
  --> https://bugs.webkit.org/attachment.cgi?id=452781
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452781&action=review

review+ assuming the tests pass

> JSTests/stress/temporal-plaindate.js:114
> +new Temporal.PlainDate(0x43530, 9, 13);

Maybe a shouldBe about the string form?

> JSTests/stress/temporal-plaindate.js:116
> +new Temporal.PlainDate(-0x425cd, 4, 20);

Ditto.