[webkit-reviews] review granted: [Bug 236995] Use ArgumentParser for parsing args in generate-compile-commands : [Attachment 452771] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brandon
<brandonstewart at apple.com>'s request for review:
Bug 236995: Use ArgumentParser for parsing args in generate-compile-commands
https://bugs.webkit.org/show_bug.cgi?id=236995

Attachment 452771: Patch

https://bugs.webkit.org/attachment.cgi?id=452771&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 452771
  --> https://bugs.webkit.org/attachment.cgi?id=452771
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452771&action=review

> Tools/Scripts/generate-compile-commands:39
> +parser = argparse.ArgumentParser(description='Generate
compile_commands.json', usage='generate-compile-commands WebKitBuild/Release')

Can/should this say something about how it's used overall, via `make
EXPORT_COMPILE_COMMANDS=YES`? I've been following this project relatively
closely, and yet I'm not sure how to set up code completion in BBEdit using
this.

Or maybe there could be a wiki page, linked from here.

> Tools/Scripts/generate-compile-commands:40
> +parser.add_argument('built_products_dir', help='path to the build directory
containing generated compile commands (ex: WebKitBuild/Release)')

This seems like it should be required=True