[webkit-reviews] review granted: [Bug 236993] [iOS] WebKit app is sometimes not "Now Playing" during initial playback : [Attachment 452764] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 21 13:37:05 PST 2022


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 236993: [iOS] WebKit app is sometimes not "Now Playing" during initial
playback
https://bugs.webkit.org/show_bug.cgi?id=236993

Attachment 452764: Patch

https://bugs.webkit.org/attachment.cgi?id=452764&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 452764
  --> https://bugs.webkit.org/attachment.cgi?id=452764
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452764&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:5715
> +#if USE(AUDIO_SESSION)
> +    m_categoryAtMostRecentPlayback =
AudioSession::sharedSession().category();
> +#endif

Don't we also want to do this before calling `m_player->playAtHostTime`?


More information about the webkit-reviews mailing list