[webkit-reviews] review granted: [Bug 232780] Add context.roundRect support to OffScreenCanvas : [Attachment 451861] Fix forward declaration

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Lauro Moura <lmoura at igalia.com>'s
request for review:
Bug 232780: Add context.roundRect support to OffScreenCanvas
https://bugs.webkit.org/show_bug.cgi?id=232780

Attachment 451861: Fix forward declaration

https://bugs.webkit.org/attachment.cgi?id=451861&action=review




--- Comment #26 from Darin Adler <darin at apple.com> ---
Comment on attachment 451861
  --> https://bugs.webkit.org/attachment.cgi?id=451861
Fix forward declaration

View in context: https://bugs.webkit.org/attachment.cgi?id=451861&action=review

> Source/WebCore/html/canvas/CanvasPath.h:37
> +#include <wtf/Forward.h>
> +
>  
>  namespace WebCore {

Please don’t add that extra blank line.

> Source/WebCore/html/canvas/CanvasPath.h:72
> +private:

Please don’t add this.

> Source/WebCore/html/canvas/CanvasPath.idl:40
> +    undefined roundRect(unrestricted double x, unrestricted double y,
unrestricted double w, unrestricted double h, sequence<(unrestricted double or
DOMPointInit)> radii);
> +    undefined roundRect(unrestricted double x, unrestricted double y,
unrestricted double w, unrestricted double h, (unrestricted double or
DOMPointInit) radii);

Still so puzzled about why we say these functions all take double in the IDL
file and then convert them all to float in the bindings by passing the double
to an internal function that takes a float. Not new to this patch, but not good
for the future.