[webkit-reviews] review granted: [Bug 236902] [WebGPU] Tracer bullet part 8: Basic implementation of device creation routines : [Attachment 452668] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 236902: [WebGPU] Tracer bullet part 8: Basic implementation of device
creation routines
https://bugs.webkit.org/show_bug.cgi?id=236902

Attachment 452668: Patch

https://bugs.webkit.org/attachment.cgi?id=452668&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 452668
  --> https://bugs.webkit.org/attachment.cgi?id=452668
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452668&action=review

> Source/WebGPU/ChangeLog:9
> +	   implemented yet, so for now we claim every limits is 0.

typo: limits

> Source/WebGPU/WebGPU/Adapter.mm:63
> +    properties->driverDescription = "";

Not emptyString()?