[webkit-reviews] review granted: [Bug 236898] [WebGPU] Tracer bullet part 5: Give Metal objects to WebGPU objects : [Attachment 452667] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 236898: [WebGPU] Tracer bullet part 5: Give Metal objects to WebGPU objects
https://bugs.webkit.org/show_bug.cgi?id=236898

Attachment 452667: Patch

https://bugs.webkit.org/attachment.cgi?id=452667&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 452667
  --> https://bugs.webkit.org/attachment.cgi?id=452667
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452667&action=review

> Source/WebGPU/WebGPU/BindGroup.h:53
> +    id <MTLBuffer> m_vertexArgumentBuffer { nil };
> +    id <MTLBuffer> m_fragmentArgumentBuffer { nil };
> +    id <MTLBuffer> m_computeArgumentBuffer { nil };
>  };

I think we do id<MTLBuffer> (without the space), here and elsewhere.