[webkit-reviews] review granted: [Bug 236891] [WebGPU] Tracer bullet part 4: Move Device's construction methods to the files of the things they create : [Attachment 452654] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 21 09:22:35 PST 2022
Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 236891: [WebGPU] Tracer bullet part 4: Move Device's construction methods
to the files of the things they create
https://bugs.webkit.org/show_bug.cgi?id=236891
Attachment 452654: Patch
https://bugs.webkit.org/attachment.cgi?id=452654&action=review
--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 452654
--> https://bugs.webkit.org/attachment.cgi?id=452654
Patch
I'm not sure this is any better. Now one needs to remember that Device::create
methods are not in Device.mm. But either way is fine.
More information about the webkit-reviews
mailing list