[webkit-reviews] review granted: [Bug 236901] Origin file may not be created after migrating data to general storage directory : [Attachment 452676] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 236901: Origin file may not be created after migrating data to general
storage directory
https://bugs.webkit.org/show_bug.cgi?id=236901

Attachment 452676: Patch

https://bugs.webkit.org/attachment.cgi?id=452676&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 452676
  --> https://bugs.webkit.org/attachment.cgi?id=452676
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452676&action=review

R=me

> Source/WebKit/ChangeLog:18
> +	   old behavior that synchronouly writes origin file at creation of
OriginStorageManager. To sovle the delay issue,

Typo: solve

> Source/WebKit/ChangeLog:19
> +	   in the sync message handler
(NetworkStorageManager::connectToStorageArea), we specifically asks to not
write 

Typo: ask

> Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:726
> +    // Avoid delay in replying sync message by delay writing origin to file.

By delaying