[webkit-reviews] review granted: [Bug 236844] Add assertion that no two network session share the same storage path : [Attachment 452586] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 236844: Add assertion that no two network session share the same storage
path
https://bugs.webkit.org/show_bug.cgi?id=236844

Attachment 452586: Patch

https://bugs.webkit.org/attachment.cgi?id=452586&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 452586
  --> https://bugs.webkit.org/attachment.cgi?id=452586
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452586&action=review

r=me

> Source/WebKit/ChangeLog:3
> +	   Add assertion that no two network session share the same storage
path

sessions (plural)

> Source/WebKit/ChangeLog:8
> +	   Each NetworkStorageManager has its own queue and access the storage
files on that queue, so we can't have two

accesses

> Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:115
> +    static NeverDestroyed<HashSet<String>> paths;

I just learned today that you can use MainThreadNeverDestroyed (and drop your
main thread assertion above).