[webkit-reviews] review granted: [Bug 236747] Make input element UA shadow tree creation lazy : [Attachment 452578] Patch v1.2

[bugzilla-daemon at webkit.org]

Aditya Keerthi <akeerthi at apple.com> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 236747: Make input element UA shadow tree creation lazy
https://bugs.webkit.org/show_bug.cgi?id=236747

Attachment 452578: Patch v1.2

https://bugs.webkit.org/attachment.cgi?id=452578&action=review




--- Comment #18 from Aditya Keerthi <akeerthi at apple.com> ---
Comment on attachment 452578
  --> https://bugs.webkit.org/attachment.cgi?id=452578
Patch v1.2

View in context: https://bugs.webkit.org/attachment.cgi?id=452578&action=review

> Source/WebCore/html/InputType.h:209
> +    bool createdShadowSubtree() const { return m_createdShadowSubtree; }

I know I suggested renaming this from `createdShadowSubtreeIfNeeded` to
`createdShadowSubtree`, but I think an even better name (matching WebKit style)
is `hasShadowSubtree` (and m_hasShadowSubtree).