[webkit-reviews] review granted: [Bug 236842] [Live Text] Add a mechanism to inject images into image overlays : [Attachment 452545] Fix watchOS build (again)

[bugzilla-daemon at webkit.org]

Aditya Keerthi <akeerthi at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 236842: [Live Text] Add a mechanism to inject images into image overlays
https://bugs.webkit.org/show_bug.cgi?id=236842

Attachment 452545: Fix watchOS build (again)

https://bugs.webkit.org/attachment.cgi?id=452545&action=review




--- Comment #6 from Aditya Keerthi <akeerthi at apple.com> ---
Comment on attachment 452545
  --> https://bugs.webkit.org/attachment.cgi?id=452545
Fix watchOS build (again)

View in context: https://bugs.webkit.org/attachment.cgi?id=452545&action=review

> Source/WebCore/dom/ImageOverlay.cpp:227
> +static void installStyleSheet(ShadowRoot& shadowRoot)

Consider renaming to `installImageOverlayStyleSheet`.

> Source/WebCore/dom/ImageOverlay.cpp:679
> +    RefPtr imageOverlayRoot =
dynamicDowncast<HTMLDivElement>(static_cast<TreeScope&>(shadowRoot.get()).getEl
ementById(imageOverlayElementIdentifier()));

Is the static cast to `TreeScope` necessary?

> Source/WebCore/dom/ImageOverlay.h:28
> +#include "FloatRect.h"

Can this be forward declared?